Fix build: Use Sidekiq Explicit Configuration #45310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanitoFatas
changed the title
Reference commit: sidekiq/sidekiq@67daa7a While the docs[1] suggests to use Sidekiq::Config, but it is not available yet. So uses Sidekiq instead to make activejob integration tests work. [1]https://github.com/mperham/sidekiq/blob/main/docs/global_to_local.md#explicit-configuration
JuanitoFatas
force-pushed
the
fix-active-job-tests-for-sidekiq-650
branch
from
0340231
to
6e6e2b9
Compare
JuanitoFatas
changed the title
|
The build is failing because ruby 3.1 uses Sidekiq 6.4.2 while ruby 2.7 and ruby 3.0 uses Sidekiq 6.5.0... https://buildkite.com/rails/rails/builds/87124#0181490c-cb14-402a-b443-09af22aa6702
|
eileencodes
added a commit
that referenced
this pull request
Jun 10, 2022
…sidekiq-650 Fix build: Use Sidekiq Explicit Configuration
byroot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…sidekiq-650 Fix build: Use Sidekiq Explicit Configuration
eileencodes
added a commit
that referenced
this pull request
Jul 12, 2022
…sidekiq-650 Fix build: Use Sidekiq Explicit Configuration
eileencodes
added a commit
that referenced
this pull request
Jul 12, 2022
…sidekiq-650 Fix build: Use Sidekiq Explicit Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Job tests for Sidekiq starts to fail since buildkite rails/rails/#87116 because Sidekiq 6.5.0 has API changes on how to configure Sidekiq. The new API does not accept hash anymore, so This Pull Request changes to how it is supposed to be configured (see here that a
configis actually theSidekiqmodule).After sidekiq/sidekiq#5225 / sidekiq/sidekiq#5329 is implemented, use the new
Sidekiq::ConfigAPI.View Active Job Integration Test Failure
Summary
Fixes ActiveJob integration tests that failed to start Sidekiq worker due to Sidekiq API changes.